Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fully-qualified syntax in triple! for calling from_str #92

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Use fully-qualified syntax in triple! for calling from_str #92

merged 1 commit into from
Jul 18, 2023

Conversation

ids1024
Copy link
Contributor

@ids1024 ids1024 commented Jul 18, 2023

This way the caller doesn't need to import FromStr.

bjorn3
bjorn3 reviewed Jul 18, 2023
View reviewed changes
src/triple.rs Outdated Show resolved Hide resolved
@ids1024
Use fully-qualified syntax in triple! for calling from_str
ef097d7 
This way the caller doesn't need to import `FromStr`.
@sunfishcode
Copy link
Member

Thanks!

@sunfishcode sunfishcode merged commit 65721ed into bytecodealliance:main Jul 18, 2023
12 checks passed
@sunfishcode
Copy link
Member

This is now released in 0.12.10.

@ids1024 ids1024 deleted the fully-qualified branch July 18, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ids1024 @sunfishcode @bjorn3