Added Missing Include: ostream #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To reproduce the issue, we could move the wasmtime.hh include in hello.cc to be the first one (before the iostream include). I could include that change if you'd like. |
|
And yeah if you're up for it having this reproduce in CI I think would be good too |
Daniel9z
force-pushed
the
main
branch
3 times, most recently
from
392af80 to
e07dbc5
Compare
|
Ok, I got CI to fail with the exact same error I saw locally when I pushed this (f4c369f) change. The change was simple, just include the wasmtime.hh header first: Resulting CI Error: I adjusted this pull request with the updated example and, if CI passes, this will confirm the issue is resolved. |
…tream is used so commonly that it's usually included by some other header. However, if you use wasmtime.hh as your first (or only) include, then you get a massive compile error on Apple toolchain compilers (I'm using xcode 16). The error does not reproduce on Linux.
The error when this include is missing is:
```
include/wasmtime.hh:519:32: error: invalid operands to binary expression ('std::ostream' (aka 'basic_ostream<char>') and 'const char[4]')
519 | WASMTIME_FOR_EACH_VAL_KIND(CASE_KIND_PRINT_NAME)
third-party/wasmtime-cpp/include/wasmtime.hh:504:3: note: expanded from macro 'WASMTIME_FOR_EACH_VAL_KIND'
504 | X(I32, "i32", WASM_I32) \
| ^~~~~~~~~~~~~~~~~~~~~~~
third-party/wasmtime-cpp/include/wasmtime.hh:517:8: note: expanded from macro 'CASE_KIND_PRINT_NAME'
517 | os << name; \
```
alexcrichton
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ValKind::operator<< uses ostream, but the include was missing. ostream is used so commonly that it's usually included by some other header. However, if you use wasmtime.hh as your first (or only) include, then you get a massive compile error on Apple toolchain compilers (I'm using xcode 16). The error does not reproduce on Linux.
The error when this include is missing is: