Adjusting the function passed to func_new/func_wrap to be universal reference so that we can perfectly forward it on. #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusting the function passed to func_new/func_wrap to be universal reference so that we can perfectly forward it on.
The issue, as shown by the test cases, is that previously the function was always copied when passed to func_new/wrap. This works fine for pointers, but when using a callable (like a lambda) it's unnecessarily copied. Furthermore, for callables which aren't allowed to be copied compilation actually fails.
The fix is to move the callable when the callable is passed in as an xvalue.
Tests failing before these changes: https://github.com/bytecodealliance/wasmtime-cpp/actions/runs/12304195157?pr=62
Error: