feat(go-namespaces): Split generated Go files into multiple packages #784
+424
−146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit overhauls the `WorldGenerator` file structure in the tinygo bindgen. Key changes include: - Splitting generated Go files into different packages for each interface, imported functions, and exported functions. - Simplifying function and symbol names by removing namespaces. - Adding a `package_name` option to Go bindgen for prefixed package names. Defaults to `main` if not specified. Internally, the C files are placed at a special Go package named "c_files_", and a dummy Go file is generated to expose the C APIs. Each interface generates a Go package that imports this special "c_files_" package to get the C apis. It still has to import the C header file which is also placed at "c_files_" by setting CFLAGS to locate where that is for that Go package. This restructuring enhances usability by making symbol and function names more readable and less verbose, significantly improving the user experience. Signed-off-by: Jiaxiao Zhou (Mossaka) <[email protected]>
Mossaka
changed the title
|
This work has been paused for a few months since there is a new pure-Go implementation of the wit-bindgen-go undergoing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit overhauls the
WorldGeneratorfile structure in the tinygo bindgen. Key changes include:package_nameoption to Go bindgen for prefixed package names. Defaults tomainif not specified.Internally, the C files are placed at a special Go package named "c_files_", and a dummy Go file is generated to expose the C APIs. Each interface generates a Go package that imports this special "c_files_" package to get the C apis. It still has to import the C header file which is also placed at "c_files_" by setting CFLAGS to locate where that is for that Go package.
This restructuring enhances usability by making symbol and function names more readable and less verbose, significantly improving the user experience.
TODO
mainfile for each codegen test, and thatmainfile needs to import all the generated Go packages.