Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tf-frontend] fix bug of creating f16 const in concat canonicalize pattern #114

Merged
merged 1 commit into from
Feb 2, 2024
Merged

[tf-frontend] fix bug of creating f16 const in concat canonicalize pattern #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions ...nd/external/patches/tensorflow/fix-bug-of-create-f16-const-for-HoistCwiseBinaryOutO.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
From 3a14562a78e712a1ea495ab0a6ba55b3afbc6ef0 Mon Sep 17 00:00:00 2001
From: "quanbo.liu" <[email protected]>
Date: Mon, 22 Jan 2024 10:04:42 +0800
Subject: [PATCH] fix bug of create f16 const for HoistCwiseBinaryOutOfConcat

---
.../compiler/mlir/tensorflow/ir/tf_ops_a_m.cc | 22 +++++++++++++------
1 file changed, 15 insertions(+), 7 deletions(-)

diff --git a/tensorflow/compiler/mlir/tensorflow/ir/tf_ops_a_m.cc b/tensorflow/compiler/mlir/tensorflow/ir/tf_ops_a_m.cc
index f66c996f32a..2b61a57f488 100644
--- a/tensorflow/compiler/mlir/tensorflow/ir/tf_ops_a_m.cc
+++ b/tensorflow/compiler/mlir/tensorflow/ir/tf_ops_a_m.cc
@@ -1317,12 +1317,12 @@ LogicalResult HoistCwiseBinaryOutOfConcat::matchAndRewrite(
// Process `exceptions`: For each value there, synthesize a binary op of the
// above kind, so that the concat hoisting optimization can still apply.
if (!exceptions.empty()) {
- int identity_val;
+ float identity_val;
if (isa<AddOp>(first_arg_op) || isa<SubOp>(first_arg_op))
- identity_val = 0;
+ identity_val = 0.0;
else if (isa<MulOp>(first_arg_op) || isa<DivOp>(first_arg_op) ||
isa<RealDivOp>(first_arg_op))
- identity_val = 1;
+ identity_val = 1.0;
else
return failure();
DenseElementsAttr const_attr;
@@ -1331,11 +1331,19 @@ LogicalResult HoistCwiseBinaryOutOfConcat::matchAndRewrite(
.getType()
.dyn_cast<ShapedType>();
Type scalar_dtype = scalar_tensor_type.getElementType();
- if (scalar_dtype.isa<FloatType>())
- const_attr = DenseElementsAttr::get(scalar_tensor_type,
- static_cast<float>(identity_val));
- else
+ if (scalar_dtype.isa<FloatType>()) {
+ //const_attr = DenseFPElementsAttr::get(scalar_tensor_type, APFloat(identity_val));
+ APFloat epsilonFloat = APFloat(identity_val);
+ bool losesInfo = false;
+ auto status = epsilonFloat.convert(
+ scalar_dtype.cast<FloatType>().getFloatSemantics(), APFloat::rmNearestTiesToEven, &losesInfo);
+ if(losesInfo || status != llvm::APFloatBase::opStatus::opOK) {
+ return op.emitError("float type conversion failed");
+ }
+ const_attr = DenseElementsAttr::get(scalar_tensor_type, epsilonFloat);
+ } else {
return failure();
+ }

// All checks are passes, and we now prepare for rewrite.
auto identity_const = rewriter.create<TF::ConstOp>(loc, const_attr);
--
2.30.2

Loading