Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][E2E]Fix e2e errors #258

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[WIP][E2E]Fix e2e errors #258

wants to merge 4 commits into from

Conversation

Xinyu302
Copy link

  1. When we run affine-opt in the e2e pipeline, it will fail at fold-memref-alias-ops pass.
module {
  func.func @fold_static_stride_subview_with_affine_load_store(%arg0: memref<12xf32>, %arg1: index, %arg2: index, %arg3: index, %arg4: index) {
    %c0 = arith.constant 0 : index
    %c1 = arith.constant 1 : index
    %c10 = arith.constant 10 : index
    scf.for %arg5 = %c0 to %c10 step %c1 {
      %subview = memref.subview %arg0[%arg5] [1] [1] : memref<12xf32> to memref<f32, strided<[], offset: ?>>
      %0 = affine.load %subview[] : memref<f32, strided<[], offset: ?>>
      vector.print %0 : f32
    }
    return
  }
}

Because we generate affine.load op inside scf.for op, and it is not allowed due to scf.for has no AffineScope trait. So we do lower-affine earlier to avoid this situation.
2. Fix SetSpaceOptPipeline for reduction codegen by adding "inline" and "gpu-launch-func-to-byre" pass
3. Still some bugs in reduction codegen in Resnet18/Whole.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant