[WebConsole] Sync to github manually #1073
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duanbing
reviewed
Mar 21, 2023
duanbing
reviewed
Mar 21, 2023
data_processing/src/main/scala/com/bytedance/aml/enterprise/Main.scala
Outdated
Show resolved
Hide resolved
duanbing
reviewed
Mar 21, 2023
| assert self.is_finished(), 'Getting result before finished' | ||
| return self._inter_ids | ||
|
|
||
| def DataJoin(self, request_iterator: Iterable[hashed_data_join_pb2.DataJoinRequest], context): |
There was a problem hiding this comment.
hash joiner没用了吧？ 我觉得可以彻底删除了
There was a problem hiding this comment.
之前是有客户要才做的，还是留着吧，后面如果还有客户要用。前端也有专门的入口给它，一整条链路，拆起来也不是很方便
duanbing
previously approved these changes
Oct 23, 2023
gejielun
force-pushed
the
feat_xgli_webconsole_sync
branch
from
f96a06a
to
78e92f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sync web_console_v2, pp_lite, operator, data_processing, py_libs, tools to github, based on webconsole 2.3.33 release.