Changes for color picker kit #4
Conversation
…ColorPicker make more sence.
…er, also to make it more accurate to picker a color
KevinZhang19870314
changed the title
|
feat: add a handler for color picker kit to make it more like magnifier, which will make it more accurate to picker a color.
|
|
@smileShirely feel free to review pr, thanks! |
|
access |
There was a problem hiding this comment.
@KevinZhang19870314 I'm glad to see your PR. But could you consider split the changes to multiple PRs?
And the new feature of color picker seems to be a small problem. The picking point has a incorrect offset.
| final Matrix4 newMatrix = Matrix4.identity() | ||
| ..translate(newX, newY) | ||
| ..scale(_scale, _scale) | ||
| ..translate(-newX, -newY); | ||
| _matrix = newMatrix; | ||
| _searchPixel(dragDetails.globalPosition); | ||
| _searchPixel(Offset(newX, newY)); |
There was a problem hiding this comment.
I tested it on multiple devices and the color picking point does not work correctly. Just like the screenshot.
There was a problem hiding this comment.
I think it should be known issue in original code, not cause by the PR. @smileShirely
There was a problem hiding this comment.
Sorry.. I don't think so. The screenshot shows the same pixel has difference RGB values between yours and the original one.
There was a problem hiding this comment.
Sorry for the delay, you can see the ss below, I am using the original code and test it on one plus 8T.
The repro branch
fix: 1. fix dart warnings; 2. ColorSucker sounds weird, change it to ColorPicker make more sence.