Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Inspect policy config format #352

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Update Inspect policy config format #352

merged 3 commits into from
Oct 11, 2024

Conversation

zh-jq-b
Copy link
Member

@zh-jq-b zh-jq-b commented Oct 11, 2024

No description provided.

@zh-jq-b
Copy link
Member Author

zh-jq-b commented Oct 11, 2024

@GlenDC here are the updates for protocol inspect policy.

The first commit switched to use ProtocolInspectPolicyBuilder in AuditorConfig.

The second commit, switched to use a new config format for ProtocolInspectPolicyBuilder by has a upper default config key, and ignore all default config keys in sub rules.

The third commit, we do have a match order in AclRegexSetRule, which won't work for ProtocolInspectAction, so switched to use a separate ProtocolInspectPolicyBuilder, which depends directly on the underlying AclRule data types. This further update the config format.

@zh-jq-b zh-jq-b merged commit cdfd791 into master Oct 11, 2024
99 checks passed
@zh-jq-b zh-jq-b deleted the inspect-policy branch October 11, 2024 07:26
@GlenDC
Copy link
Contributor

GlenDC commented Oct 11, 2024

Woah @zh-jq , that's a pretty intense change still! Very cool. Thanks for that! A lot to unpack there.
Went through the commits and code changes. Great changes.

@zh-jq-b
Copy link
Member Author

zh-jq-b commented Oct 11, 2024

Woah @zh-jq , that's a pretty intense change still! Very cool. Thanks for that! A lot to unpack there. Went through the commits and code changes. Great changes.

You can just check the final diff via git diff 90c721e22e273fb3b8abd6660b66a3dc597a4a8f..c240fc60f80d2f03ce27bb5a9ce895a7b25afa2c.

@GlenDC
Copy link
Contributor

GlenDC commented Oct 11, 2024

Yes I checked it. Thanks for helping this get through :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants