增加上下文时限管理能力 #54
增加上下文时限管理能力 #54
Conversation
util/hcontext/README.md
Outdated
| @@ -0,0 +1,15 @@ | |||
| # hcontext | |||
There was a problem hiding this comment.
感觉像是对标准库 context 的增强，不如放在 lang 下，取名为 contextx？
util/hcontext/README.md
Outdated
| ## usage | ||
|
|
||
| ```golang | ||
| //移除超时信息，保留value信息 |
There was a problem hiding this comment.
在 // 后加一个空格，并且 README.md 改为英文吧，中文的可以放在 README_ZH.md 中，同时记得英文和中文间加个空格，如下：
// 移除超时信息，保留 value 信息
下同。
util/hcontext/hcontext.go
Outdated
| func (valueOnlyContext) Done() <-chan struct{} { return nil } | ||
| func (valueOnlyContext) Err() error { return nil } | ||
|
|
||
| //WithNoDeadline 移除超时控制，保留value信息 |
There was a problem hiding this comment.
comment 改成英文吧，记得 // 后加空格，下同。
util/hcontext/hcontext_test.go
Outdated
| "testing" | ||
| "time" | ||
|
|
||
| "gopkg.in/go-playground/assert.v1" |
util/hcontext/hcontext_test.go
Outdated
| stub func(*testing.T, context.Context) | ||
| }{ | ||
| { | ||
| name: "value正常传递", |
lang/contextx/contextx.go
Outdated
| func (valueOnlyContext) Done() <-chan struct{} { return nil } | ||
| func (valueOnlyContext) Err() error { return nil } | ||
|
|
||
| //WithNoDeadline only remove deadline value |
There was a problem hiding this comment.
// WithNoDeadline only remove deadline value
在 // 后加个空格吧
lang/contextx/contextx.go
Outdated
| return valueOnlyContext{ctx} | ||
| } | ||
|
|
||
| //WithNoCancel only remove cancel value |
lang/contextx/contextx.go
Outdated
| } | ||
|
|
||
| //WithNoCancel only remove cancel value | ||
| func WithNoCancel(ctx context.Context) context.Context { |
There was a problem hiding this comment.
WithNoCancel 是不是换成 WithoutCancel 或者 RemoveCancel 这样会好点？好像没有WithNo这样的 name convention
| var cancel context.CancelFunc | ||
| ctx = WithNoDeadline(ctx) | ||
| ctx, cancel = context.WithDeadline(ctx, deadline) | ||
| _ = cancel |
lang/contextx/contextx_test.go
Outdated
|
|
||
| import ( | ||
| "context" | ||
| "github.com/stretchr/testify/assert" |
lang/contextx/contextx.go
Outdated
| func (valueOnlyContext) Err() error { return nil } | ||
|
|
||
| //WithNoDeadline only remove deadline value | ||
| func WithNoDeadline(ctx context.Context) context.Context { |
There was a problem hiding this comment.
这里的注释是不是可以更详细点呢，描述下使用的情况，以免误用
从功能上来说感觉问题不大。 |
那微信讨论一下？9393103 |
|
好像例如注释这些还没解决，要不再更新下？我们的讨论过程还是尽量在 issues 里面吧，方便其他开发者找到相关的上下文 |
| func (valueOnlyContext) Done() <-chan struct{} { return nil } | ||
| func (valueOnlyContext) Err() error { return nil } | ||
|
|
||
| //RemoveDeadline only remove deadline value |
There was a problem hiding this comment.
// WithNoDeadline only remove deadline value
在 // 后加个空格吧
| return valueOnlyContext{ctx} | ||
| } | ||
|
|
||
| //RemoveCancel only remove cancel value |
| if ok { | ||
| var cancel context.CancelFunc | ||
| ctx = RemoveDeadline(ctx) | ||
| ctx, cancel = context.WithDeadline(ctx, deadline) |
There was a problem hiding this comment.
直接 ctx, _ = context.WithDeadline(ctx, deadline) 是不是就行了？
在工程场景中我们会遇到，当前上下文有超时时间、一些场景后（RPC Response）释放资源，但是我们还要继续去 执行一些任务。如果我们用到了协程池，我们可能需要传递没有超时、取消的上下文进去。�（上下文中会携带TraceID等信息用来溯源）