feat: impl Async Read/Write Rent for File
#297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihciah
reviewed
Sep 2, 2024
| } | ||
|
|
||
| async fn write<T: IoBuf>(&mut self, buf: T) -> crate::BufResult<usize, T> { | ||
| let op = Op::write(self.fd.clone(), buf).unwrap(); |
There was a problem hiding this comment.
The WriteOp(as well as ReadOp)'s legacy implementation is to directly call pwrite. This is fine for something like TcpStream(eq to send), but for file io this is a blocking action.
To make write be non-blocking, iouring/aio may help. But for legacy path, I think we can do it in an independent thread pool.
A (shared) thread pool can be attached to a runtime if it needs it. We can do blocking syscall with it. If it is not attached, we can do it inplace.
There was a problem hiding this comment.
you mean when the feature "sync" is enabled, use the thread pool to do the syscall, is that right?
If we do this, it may be necessary to change other file-related behavior like create_dir & metadata and ...
ihciah
reviewed
Sep 6, 2024
Signed-off-by: lzzzt <[email protected]>
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements AsyncReadRent and AsyncWriteRent for File, completing the following tasks:
op::read<T>andop::write<T>to support reading/writing files using the file pointer.OVERLAPPEDstruct to reduce the number of syscalls.readvandwritevwould always start from the beginning of the file.readvandwritevon Windows.readvandwritevby continually calling thereadandwritefunctions.AsyncWriteRentandAsyncReadRent.readv/writev-like syscalls on the Windows platform, the structure ofsrc/fs/file.rswas changed for better readability of the implementations on different platforms.Other details are shown in the code.
Related Issue
#266
#291