fix: shouldn't use stack-pointer to avoid stackgrow problem #515
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason
Since this place reference a pointer from the stack, once stackgrow happens after entering
encoderTypedPointer
, the pointer may be invalid and introduce potential NPE problem.Fix
Malloc a
new(unsafe.Pointer)
obj on heap and store its pointer onto stack. Then write the value pointervp
onto the objAffect
Will introduce more
malloc
when encoding large structure. For our test sample Twitter, it will cause 6%~8% downgrades of performance