fix: enable fuzz tests and fix decoder bugs

dev/decoder/functor.go

@@ -53,11 +53,7 @@ func (d *embeddedFieldPtrDecoder) FromDom(vp unsafe.Pointer, node internal.Node,
 	}
 
 	vp = unsafe.Pointer(uintptr(vp) + d.offset)
-	err := d.fieldDec.FromDom(vp, node, ctx)
-	if err != nil {
-		return err
-	}
-	return nil
+	return d.fieldDec.FromDom(vp, node, ctx)
 }
 
 type i8Decoder struct{}

dev/decoder/structs.go

@@ -27,7 +27,7 @@ func (d *structDecoder) FromDom(vp unsafe.Pointer, node internal.Node, ctx *cont
 	var gerr error
 	obj, err := node.AsObj()
 	if err != nil {
-		return nil
+		return err
 	}
 
 	next := obj.Children()
@@ -36,7 +36,7 @@ func (d *structDecoder) FromDom(vp unsafe.Pointer, node internal.Node, ctx *cont
 		val := internal.NewNode(internal.PtrOffset(next, 1))
 		next = val.Next()
 		if err != nil {
-			return nil
+			return err
 		}
 
 		idx := d.fieldMap.TryGet(key, i)

dev/internal/rt_stubs_go116.go

@@ -41,7 +41,7 @@ func MakeSlice(oldPtr unsafe.Pointer, et *rt.GoType, newLen int) *rt.GoSlice {
 		return old
 	}
 
-	new := growslice(et, *old, newLen-old.Len)
+	new := growslice(et, *old, newLen)
 	// growslice does not zero out new[old.cap:new.len] since it assumes that
 	// the memory will be overwritten by an append() that called growslice.
 	// Since the caller of reflect_growslice is not append(),

dev/internal/sonic_rs.go

@@ -483,7 +483,7 @@ func (node *Node) AsMapEface(ctx *Context, vp unsafe.Pointer) error {
 func (node *Node) AsMapEfaceUseNumber(ctx *Context, vp unsafe.Pointer) error {
 	obj, err := node.AsObj()
 	if err != nil {
-		return nil
+		return err
 	}
 
 	size := obj.Len()
@@ -517,7 +517,7 @@ func (node *Node) AsMapEfaceUseNumber(ctx *Context, vp unsafe.Pointer) error {
 func (node *Node) AsMapEfaceUseInt64(ctx *Context, vp unsafe.Pointer) error {
 	obj, err := node.AsObj()
 	if err != nil {
-		return nil
+		return err
 	}
 
 	size := obj.Len()

fuzz/Makefile

@@ -1,16 +1,19 @@
 testname  := FuzzMain
 corpusdir := ./testdata/fuzz/${testname}
+go := go
 
-fuzz: 
+fuzz:
+	${go} version
 	mkdir -p ${corpusdir}
 	rm -rf ./go-fuzz-corpus
 	git clone https://github.com/dvyukov/go-fuzz-corpus.git ./go-fuzz-corpus/
-	go install golang.org/x/tools/cmd/file2fuzz@latest
+	${go} install golang.org/x/tools/cmd/file2fuzz@latest
 	file2fuzz -o ${corpusdir} ./go-fuzz-corpus/json/corpus/*  ./corpus/* 
 
 run:
-	SONIC_FUZZ_MEM_LIMIT=2 GOMAXPROCS=4 go test -fuzz=${testname} -v -fuzztime 10m
-
+	${go} version
+	SONIC_FUZZ_MEM_LIMIT=2 GOMAXPROCS=4 ${go} test -fuzz=${testname} -v -fuzztime 10m
+
 clean:
 	rm -rf ./go-fuzz-corpus/
 	rm -rf ./testdata/

fuzz/fuzz_test.go

@@ -1,3 +1,4 @@
+//go:build go1.18
 // +build go1.18
 
 /*
@@ -19,21 +20,21 @@
 package sonic_fuzz
 
 import (
-    `encoding/json`
-    `testing`
-    _ `unicode/utf8`
-    `os`
-    `runtime`
-    `runtime/debug`
-    `time`
-    `io`
-    `log`
-    `strconv`
-
-    `github.com/bytedance/sonic`
-    `github.com/stretchr/testify/require`
-    `github.com/davecgh/go-spew/spew`
-    `github.com/bytedance/gopkg/util/gctuner`
+	"encoding/json"
+	"io"
+	"log"
+	"os"
+	"runtime"
+	"runtime/debug"
+	"strconv"
+	"testing"
+	"time"
+	"unicode/utf8"
+
+	"github.com/bytedance/gopkg/util/gctuner"
+	"github.com/bytedance/sonic"
+	"github.com/davecgh/go-spew/spew"
+	"github.com/stretchr/testify/require"
 )
 
 func FuzzMain(f *testing.F) {
@@ -46,6 +47,7 @@ func FuzzMain(f *testing.F) {
 // Used for debug falied fuzz corpus
 func TestCorpus(t *testing.T) {
     fuzzMain(t, []byte("[1\x00"))
+	// fuzzMain(t, []byte("3469446951536141862700000000000000000e-62"))
     fuzzMain(t, []byte("\"\\uDE1D\\uDE1D\\uDEDD\\uDE1D\\uDE1D\\uDE1D\\uDE1D\\uDEDD\\uDE1D\""))
     // fuzzMain(t, []byte(`{"":null}`))
 }
@@ -57,8 +59,9 @@ func fuzzMain(t *testing.T, data []byte) {
     fuzzHtmlEscape(t, data)
     // fuzz ast get api, should not panic here.
     fuzzAst(t, data)
-    // Only fuzz the validate json here.
-    if !json.Valid(data) {
+    // Rust std repr invalid utf8 chars is diff from Golang,
+	// so we skip invalid utf8 here.
+    if !json.Valid(data) || !utf8.Valid(data) {
         return
     }
     fuzzStream(t, data)
@@ -82,7 +85,7 @@ func fuzzMain(t *testing.T, data []byte) {
         if jerr != nil {
             continue
         }
-        require.Equal(t, sv, jv, dump(data, jv, jerr, sv, serr))
+        require.Equal(t, jv, sv, dump(string(data), jv, jerr, sv, serr))
 
         v := jv
         sout, serr := target.Marshal(v)