Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aarch64): invalid skip number #712

Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix(aarch64): invalid skip number #712

merged 1 commit into from
Nov 20, 2024

Conversation

liuq19
Copy link
Collaborator

@liuq19 liuq19 commented Nov 20, 2024

No description provided.

}

func isSpace(c byte) bool {
return c == ' ' || c == '\t' || c == '\n' || c == '\r'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IsSpace不是一直都用更快的Go实现?

func isSpace(c byte) bool {
要不也统一下到一个地方?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ast 那里做了编译错误提示的 hack,这里不太好统一。而且这个函数太小了

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 51.96%. Comparing base (9e5bbc5) to head (7ef0232).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
internal/decoder/optdec/helper.go 0.00% 10 Missing ⚠️
internal/decoder/optdec/node.go 0.00% 3 Missing ⚠️
ast/decode.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #712      +/-   ##
==========================================
+ Coverage   51.85%   51.96%   +0.11%     
==========================================
  Files         130      129       -1     
  Lines       11020    10889     -131     
==========================================
- Hits         5714     5659      -55     
+ Misses       4971     4908      -63     
+ Partials      335      322      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@AsterDY AsterDY merged commit e2ff8ac into main Nov 20, 2024
34 of 49 checks passed
@AsterDY AsterDY deleted the fix/raw branch November 20, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants