update: fix bug on sleeping reader #214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coanor
commented
Dec 13, 2020
•
coanor
commented
|
Thank you for your pull request. But seemingly this PR makes the CPU usage 100% due to busy loop. To fix the problem, we need to use solution like the following snippet. I'm sorry for your inconvenience. I have no enough time to fix this bug. |
|
Maybe you have not review all the code(no enought time ;) I have removed The only defect is, the reading /dev/tty goroutine is leaked until os.Exit(), but this is not a serious problem(always only one reading groutine running). And I think we can merge the two groutine into 1, then no conmmunication need between them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.