Fix error when make outline summary. #28
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the outline function, we iterate through each header and its paragraph. In each iteration, we pass this paragraph to functions that remove images, links, etc. But those functions accept the path of the README.md file, so the error "Invalid file. Only Markdown files (.md) are supported." raised.
To solve this problem, I changed the input parameter to accept the markdown content as a string and removed the reading file code from the implementation. I also checked if those functions are used in another place to avoid conflict and found that they are used only in the outline function.
Each function reads the file from given path. However, if we want to remove images, links, etc. from one README.md file, we need after each function call to write the output to the file again to be able to use the other functions, and it doesn't make sense.