#10191 Feat: Auto ordering of groups on comparision tab done #4839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cbioportalfrontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alisman
reviewed
Feb 6, 2024
| @@ -206,6 +206,15 @@ export default class GroupSelector extends React.Component< | |||
| index={buttons.length} | |||
| /> | |||
| ); | |||
| // Logic To Put Primary First | |||
There was a problem hiding this comment.
i think we need to extract the logic here (163 onward) and put it in a testable function. also we shouldn't be "editing" the props of a group. we need to use functional approach and produce a new ordered data (or do ordering upstream)
There was a problem hiding this comment.
True that, allow me some time to work on this. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cBioPortal/cbioportal #10191
Describe changes proposed in this pull request: