Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto order some groups on comparison page #10191

Open
2 tasks
inodb opened this issue May 23, 2023 · 5 comments · May be fixed by cBioPortal/cbioportal-frontend#5099
Open
2 tasks

Auto order some groups on comparison page #10191

inodb opened this issue May 23, 2023 · 5 comments · May be fixed by cBioPortal/cbioportal-frontend#5099
Assignees
@amanbhardwaj12072003
Labels
enhancement good first issue

Comments

@inodb
Copy link
Member

inodb commented May 23, 2023 •
edited
Loading

It would be nice if we could add some auto-ordering of groups on the comparison page. A few simple rules for ordering temporarily could help:

  • primary should be before metastasis (see e.g. this example)

    image

    It would be more intuitive to list the "(A) Primary", and "(B) Metastasis"

  • Similar a pre treatment group should be before post treatment group
@amanbhardwaj12072003
Copy link
Contributor

Hey, Is the issue still open? I would love to work on this one.

@inodb
Copy link
Member Author

inodb commented Jan 31, 2024

@amanbhardwaj12072003 it's still open - would be great to see your contribution. Thanks so much!

@amanbhardwaj12072003
Copy link
Contributor

Hey @inodb, I'm wondering which file/folder/component am I supposed to work with. Your example link isn't working fine.
Can you please attach some image(s) regarding the same?

@amanbhardwaj12072003
Copy link
Contributor

Hey @inodb, Kindly approve my PR, Thanks!

@amanbhardwaj12072003 amanbhardwaj12072003 mentioned this issue Feb 1, 2024
Closed
@inodb inodb removed the discussion label Jan 17, 2025
@rishisulakhe rishisulakhe linked a pull request Feb 1, 2025 that will close this issue
Open
3 tasks
@rishisulakhe
Copy link

Hey @alisman , @inodb
Made a pull request for this issue.
cBioPortal/cbioportal-frontend#5099

Thankyou!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amanbhardwaj12072003 amanbhardwaj12072003

Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat : Ordering some groups on comparison page rishisulakhe/cbioportal-frontend2
4 participants
@inodb @dippindots @amanbhardwaj12072003 @rishisulakhe