Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample Decryption and Redirects for Epic #10997

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Sample Decryption and Redirects for Epic #10997

merged 1 commit into from
Jan 10, 2025

Conversation

averyniceday
Copy link
Contributor

@averyniceday averyniceday commented Sep 17, 2024

Describe changes proposed in this pull request:
Add support for new endpoints that handle redirects from Epic. Includes calls to Mpath server for decrypting IDs before generating redirects. Includes the following additions:

  • Endpoint (/api-legacy/epic/sample/{sampleID}): takes an encrypted sample ID, decrypts, and redirects to the appropriate sample
  • Endpoint (/api-legacy/epic/patient/{patientID}): takes an encrypted patient ID, decrypts, and redirects to the appropriate patient
  • Endpoint (api-legacy/epic/{sampleID}/exists): takes encrypted sampleID, decrypts, and checks for existence (for determining whether to add a linkout from Epic)
  • Property (mpath.token): optional, contains api-key for using the decryption server
  • Property (mpath.decryption_url): optional, contains URL to decryption server

@averyniceday averyniceday force-pushed the demo-cisintegration branch 2 times, most recently from 4e5e710 to bfe778f Compare September 17, 2024 19:20
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 New Bugs (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@averyniceday averyniceday requested a review from inodb November 4, 2024 16:04
@inodb inodb added the skip-changelog Do not show this PR in the release notes label Nov 4, 2024
Copy link

sonarqubecloud bot commented Nov 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)
1 New Bugs (required ≤ 0)
1 New Vulnerabilities (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@averyniceday
Copy link
Contributor Author

@inodb can we merge and deploy this sometime this week? Will also need to add SSL certs to the deployment, I can help with that

@inodb inodb removed the do not merge label Jan 9, 2025
Add new properties for server url and key
@inodb
Copy link
Member

inodb commented Jan 9, 2025

@averyniceday just rebased it - i think fine to merge if the tests pass

I added a follow up ticket about how to better handle custom MSK code as pointed out by @haynescd : #11329

Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
1 New Bugs (required ≤ 0)
C Security Rating on New Code (required ≥ A)
1 New Vulnerabilities (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@inodb inodb merged commit fc6e424 into master Jan 10, 2025
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Do not show this PR in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants