Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MineProcess stalling on blocks which are canWalkThrough but shouldn't be broken #4662

Open
wants to merge 2 commits into
base: 1.19.4
Choose a base branch
from
+5 −2
Open

Fix MineProcess stalling on blocks which are canWalkThrough but shouldn't be broken #4662

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3086c2
Filter blocks where `avoidBreaking` returns false
ZacSharp Feb 27, 2025
f357eb2
Remove spam
ZacSharp Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/main/java/baritone/process/MineProcess.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ public PathingCommand onTick(boolean calcFailed, boolean isSafeToCancel) {
int curr = ctx.player().getInventory().items.stream()
.filter(stack -> filter.has(stack))
.mapToInt(ItemStack::getCount).sum();
System.out.println("Currently have " + curr + " valid items");
if (curr >= desiredQuantity) {
logDirect("Have " + curr + " valid items");
cancel();
Expand Down Expand Up @@ -486,7 +485,11 @@ public static boolean isNextToAir(CalculationContext ctx, BlockPos pos) {


public static boolean plausibleToBreak(CalculationContext ctx, BlockPos pos) {
if (MovementHelper.getMiningDurationTicks(ctx, pos.getX(), pos.getY(), pos.getZ(), ctx.bsi.get0(pos), true) >= COST_INF) {
BlockState state = ctx.bsi.get0(pos);
if (MovementHelper.getMiningDurationTicks(ctx, pos.getX(), pos.getY(), pos.getZ(), state, true) >= COST_INF) {
return false;
}
if (MovementHelper.avoidBreaking(ctx.bsi, pos.getX(), pos.getY(), pos.getZ(), state)) {
return false;
}

Expand Down
Loading