This repository was archived by the owner on Feb 21, 2020. It is now read-only.

Make transport more flexible by refactor functionality to own functions #5

Merged

niftylettuce merged 1 commit into cabinjs:master from stanogurnik:make-transport-more-flexible

Jul 30, 2018

Contributor

stanogurnik commented May 2, 2018 •

edited

Loading

This way bits of transport can be easily adjusted by overloading:

class MyCustomSentry extends Sentry {
    _normalizeMessage(msg, meta) {
         return 'Custom message for all Errors'; // this makes no sense but illustrates usage
    }
}


          Make transport more flexible by refactor functionality to own functions

7329ee0

thevojacek approved these changes

View reviewed changes

stanogurnik mentioned this pull request

Passing an array to error meta raises an exception. #4

Closed

niftylettuce merged commit 6e35eb5 into cabinjs:master

Collaborator

niftylettuce commented Jul 30, 2018

Released in v2.0.0 btw, sorry for delay

stanogurnik deleted the make-transport-more-flexible branch

August 6, 2018 14:16

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet