-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Include tracking of GOOS for which Caddy fails to build #3617
Conversation
4254c5f
to
2a70844
Compare
2a70844
to
131aa7c
Compare
c08c6ac
to
46f2e4b
Compare
46f2e4b
to
ce335bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll dig deeper later but at a glance:
70c8275
to
0fc1bf6
Compare
0fc1bf6
to
c9e85b8
Compare
FYI @mholt unfortunately github actions doesn't have a "warning" state for jobs yet, but there's an open issue discussing it here actions/runner#2347 So for now, we have |
Co-authored-by: Francis Lavoie <[email protected]>
This looks cool, neat idea! I can see why this would be even better with some sort of "warning" result instead of just green/red. I guess something we can add to our TODO list is to submit patches upstream, or at least request that they make their build tags more correct, so that we can continue to build x-platform. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this ready to merge or should we wait? Is it even useful if it always emits a green status?
It is ready. The results always being green bothers me too, but I hope the workflow being listed reminds to check for annotations... until Github Actions supports tri-state results. |
Blocked by #3625 😓 (kinda, sorta) |
My bad. Will get that figured out soon. |
Okie all fixed |
We learned about the build failure for Solaris by accident. Perhaps it's better we have track of which OSs Caddy fails to build for to have an understanding our areas of improvements and where we are probably unable to support.
Updates #3615