Configurable idle conn counts for connection pooling #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
|
@francislavoie Can you remove the |
francislavoie
force-pushed
the
pooling-config
branch
from
4b5025f to
877b2ca
Compare
|
I hijacked this a bit to bump the minimum to v2.8.4 and set up |
francislavoie
force-pushed
the
pooling-config
branch
from
877b2ca to
81528fc
Compare
mholt
approved these changes
Jan 15, 2025
|
@mholt I don't have permissions on this repo 😛 |
|
Oops! Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default of 50 conns globally is a fine default, but in some cases allowing that limit to be unbound or tuned higher may be necessary to make better use of Go's connection pooling if there's a lot of different hosts being connected to through the proxy.