Skip to content

Commit

Permalink
Skipping racy tests (#1375)
Browse files Browse the repository at this point in the history
  • Loading branch information
3vilhamster authored Oct 31, 2024
1 parent 847db44 commit 163f1a9
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions internal/context_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ func TestContextChildParentCancelRace(t *testing.T) {
}

func TestContextConcurrentCancelRace(t *testing.T) {
t.Skip("This test is racy and not reliable. It is disabled until we can make it reliable.")
/*
A race condition existed due to concurrently ending goroutines on shutdown (i.e. closing their chan without waiting
on them to finish shutdown), which executed... quite a lot of non-concurrency-safe code in a concurrent way. All
Expand Down Expand Up @@ -104,6 +105,7 @@ func TestContextConcurrentCancelRace(t *testing.T) {
}

func TestContextAddChildCancelParentRace(t *testing.T) {
t.Skip("This test is racy and not reliable. It is disabled until we can make it reliable.")
/*
It's apparently also possible to race on adding children while propagating the cancel to children.
*/
Expand Down

0 comments on commit 163f1a9

Please sign in to comment.