Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipping racy tests #1375

Merged
merged 1 commit into from
Oct 31, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions internal/context_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ func TestContextChildParentCancelRace(t *testing.T) {
}

func TestContextConcurrentCancelRace(t *testing.T) {
t.Skip("This test is racy and not reliable. It is disabled until we can make it reliable.")
/*
A race condition existed due to concurrently ending goroutines on shutdown (i.e. closing their chan without waiting
on them to finish shutdown), which executed... quite a lot of non-concurrency-safe code in a concurrent way. All
Expand Down Expand Up @@ -104,6 +105,7 @@ func TestContextConcurrentCancelRace(t *testing.T) {
}

func TestContextAddChildCancelParentRace(t *testing.T) {
t.Skip("This test is racy and not reliable. It is disabled until we can make it reliable.")
/*
It's apparently also possible to race on adding children while propagating the cancel to children.
*/
Expand Down
Loading