add Concurrency entity for worker #1405
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| // Copyright (c) 2017-2021 Uber Technologies Inc. | ||
| // | ||
| // Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| // of this software and associated documentation files (the "Software"), to deal | ||
| // in the Software without restriction, including without limitation the rights | ||
| // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| // copies of the Software, and to permit persons to whom the Software is | ||
| // furnished to do so, subject to the following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included in | ||
| // all copies or substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| // THE SOFTWARE. | ||
|
|
||
| package worker | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| ) | ||
|
|
||
| type channelPermit struct { | ||
| channel chan struct{} | ||
| } | ||
|
|
||
| // NewChannelPermit creates a static permit that's not resizable | ||
| func NewChannelPermit(count int) ChannelPermit { | ||
| channel := make(chan struct{}, count) | ||
| for i := 0; i < count; i++ { | ||
| channel <- struct{}{} | ||
| } | ||
| return &channelPermit{channel: channel} | ||
| } | ||
|
|
||
| func (p *channelPermit) Acquire(ctx context.Context) error { | ||
| select { | ||
| case <-ctx.Done(): | ||
| return fmt.Errorf("failed to acquire permit before context is done") | ||
| case p.channel <- struct{}{}: | ||
| return nil | ||
| } | ||
| } | ||
|
Comment on lines
+41
to
+48
There was a problem hiding this comment. pretty strong sign that there need to be more tests: without a |
||
|
|
||
| // AcquireChan returns a permit ready channel | ||
| func (p *channelPermit) GetChan() <-chan struct{} { | ||
| return p.channel | ||
| } | ||
|
|
||
| func (p *channelPermit) Release() { | ||
| p.channel <- struct{}{} | ||
| } | ||
|
|
||
| // Count returns the number of permits available | ||
| func (p *channelPermit) Count() int { | ||
| return len(p.channel) | ||
| } | ||
|
|
||
| func (p *channelPermit) Quota() int { | ||
| return cap(p.channel) | ||
| } | ||
|
|
||
| // SetQuota on static permit doesn't take effect | ||
| func (p *channelPermit) SetQuota(_ int) { | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| // Copyright (c) 2017-2021 Uber Technologies Inc. | ||
| // | ||
| // Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| // of this software and associated documentation files (the "Software"), to deal | ||
| // in the Software without restriction, including without limitation the rights | ||
| // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| // copies of the Software, and to permit persons to whom the Software is | ||
| // furnished to do so, subject to the following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included in | ||
| // all copies or substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| // THE SOFTWARE. | ||
|
|
||
| package worker | ||
|
|
||
| import ( | ||
| "context" | ||
| ) | ||
|
|
||
| var _ Permit = (*resizablePermit)(nil) | ||
| var _ ChannelPermit = (*channelPermit)(nil) | ||
|
|
||
| // ConcurrencyLimit contains synchronization primitives for dynamically controlling the concurrencies in workers | ||
| type ConcurrencyLimit struct { | ||
| PollerPermit Permit // controls concurrency of pollers | ||
| TaskPermit ChannelPermit // controls concurrency of task processing | ||
| } | ||
|
|
||
| // Permit is an adaptive permit issuer to control concurrency | ||
| type Permit interface { | ||
| Acquire(context.Context) error | ||
| Count() int | ||
| Quota() int | ||
| Release() | ||
| SetQuota(int) | ||
|
There was a problem hiding this comment. Seems worth splitting this out so you don't have to no-op it. It isn't even needed - this all compiles fine with |
||
| } | ||
|
|
||
| type ChannelPermit interface { | ||
| Permit | ||
| GetChan() <-chan struct{} // fetch the underlying channel | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these methods are unnecessary after
PermitintroductionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with this removed, this is basically a "periodically update a cache and broadcast" thing, rather than a resource-controller.
which seems fine, just checking that that's what is needed. without anything using the hooks or
GetCurrent()I'm kinda struggling to figure out what's needed eventually vs something we should get rid of while we can.