Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MCT exchange matrix sensitivity to documentation #289

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

jbreue16
Copy link
Contributor

@jbreue16 jbreue16 commented Sep 20, 2024

Fixes #288

In CADET-Core for the MCT the parameters sensitivity entries of the exchange matrix can be accessed via mapping.

srcChannel => bound_phase
destChannel => sens_partype

This mapping should be added to the documentation of the EXCHANGE_MATRIX in the interface (https://cadet.github.io/master/interface/unit_operations/multi_channel_transport_model.html) similar to how it was done for the CONNECTIONS matrix (https://cadet.github.io/master/interface/system.html#group-input-model-connections).

@hannahlanzrath
Copy link
Collaborator

hannahlanzrath commented Sep 30, 2024

@jbreue16 Since you pushed the PR, I cannot appoint you as a reviewer. Maybe you can check the changes and merge as you see fit.

@jbreue16
Copy link
Contributor Author

jbreue16 commented Sep 30, 2024

The last commit had a failing CI run, probably because of #273
Hopefully @ronald-jaepel and I can fix this tomorrow and we can merge after this so that we dont end up with a failing CI on master

@hannahlanzrath
Copy link
Collaborator

hannahlanzrath commented Oct 2, 2024

@jbreue16 Note so we still remember it after the long weekend: Undo the last commit before merging :)

Adds mapping to access Parameter sensitivities to MCT documentation

fix function documentation makeParamID()
@jbreue16 jbreue16 merged commit d8de618 into master Oct 22, 2024
4 checks passed
@jbreue16 jbreue16 deleted the feature/exchange_sens branch October 22, 2024 18:21
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Parameter Sensitivities for the "EXCHANGE_MATRIX" (MCT unit)
2 participants