Fix test interdependencies #294
Merged
+350
−229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbreue16
force-pushed
the
fix/eigenRowIterator
branch
from
141eb5e
to
6ec41c4
Compare
jbreue16
force-pushed
the
fix/eigenRowIterator
branch
2 times, most recently
from
7416bed
to
54b49d9
Compare
In some loops, the RowIterator was moved beyond the matrix memory, causing memory issues even if the RowIterator was not used further. We out-of-bound safeguards are added to prevent this. A benchmark showed no impact on performance.
jbreue16
force-pushed
the
fix/eigenRowIterator
branch
2 times, most recently
from
3a48754
to
61ae8b1
Compare
The configure and configureModelDiscretization functions are called multiple times, which caused multiple allocations for some members of the unit-operations. This lead to memory leaks, which was especially severe for the DG code (e.g. 2.5 MB for a single test simulation with moderate/low discretization) since more members are allocated. This is fixed by checking if the unit-operation members are already allocated.
For the tests, some units need to initialize the AD directions with zero. This is not done sometimes when multiple tests are run: The number of AD directions used might still be set from the previous test, leading to uninitialized value errors. Thus, we set the AD directions before configuring the units. Co-authored-by: Jan Breuer <[email protected]>
jbreue16
force-pushed
the
fix/eigenRowIterator
branch
from
61ae8b1
to
73a3063
Compare
jbreue16
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found that some tests fail when they are executed in a specific order.
In the course of our investigation, we fixed multiple issues:
Fixes #273