-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove background color but not clear_frame #134
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good, before merging I just want two things discussed first.
TriColor::Black => (0x00, 00), | ||
TriColor::Chromatic => (0xFF, 00), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TriColor::Black => (0x00, 00), | |
TriColor::Chromatic => (0xFF, 00), | |
TriColor::Black => (0x00, 0x00), | |
TriColor::Chromatic => (0xFF, 0x00), |
@@ -23,6 +23,8 @@ use self::command::Command; | |||
use crate::buffer_len; | |||
|
|||
/// Full size buffer for use with the 7in5 v3 EPD | |||
// Note v2 is bicolor, cannot find v3 on the website | |||
// 7in5B v3 exists and is tricolor, but it doesn't work wit this driver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it was b v3 (https://www.waveshare.com/wiki/7.5inch_e-Paper_HAT_(B)_Manual#Introduction) (#26 (comment)). It was based of marcelbuesings original work for the 7in5bc and I though he got it working. Did you test it?
The module should be renamed to epd7in5b_v3
anyway
EDIT: I think we might be able to just delete it, since your old pr already added support for v2 and v3 for the 7in5b variant.
let color = DEFAULT_BACKGROUND_COLOR.get_byte_value(); | ||
let color = color.get_byte_value(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be used for both the black and white layer and the chromatic layer - since we're only clearing to black or white, the chromatic layer should always be left as white.
Sorry for @Liamolucko
I could not start from #108 it was too much work to re-add clear_frame