Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/casher: ItemEntityをimportに変更 #150

Merged
merged 4 commits into from
Sep 25, 2024
Merged

/casher: ItemEntityをimportに変更 #150

merged 4 commits into from
Sep 25, 2024

Conversation

Astalum
Copy link
Member

@Astalum Astalum commented Sep 25, 2024

fixes #116

ItemEntityをコピペからimportに変更

@toririm toririm self-requested a review September 25, 2024 16:14
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 450abbc):

https://cafeore-2024--pr150-issue-116-yw8fou37.web.app

(expires Wed, 02 Oct 2024 16:19:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b62dcde668e26b6280dd8317f3f875013f6f22f5

Copy link
Member

@toririm toririm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/nit

app/routes/_header.casher.tsx Show resolved Hide resolved
@toririm toririm changed the title Issue/116 /casher: ItemEntityをimportに変更 Sep 25, 2024
@Astalum Astalum merged commit 20b583e into main Sep 25, 2024
7 checks passed
@Astalum Astalum deleted the issue/116 branch September 25, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[/casher] ItemEntity~/model/item.tsからimportして使う
2 participants