/casher OrderではなくOrderEntityを使う #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit b665144): https://cafeore-2024--pr159-issue-158-lx3pwvom.web.app (expires Sun, 06 Oct 2024 08:26:11 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b62dcde668e26b6280dd8317f3f875013f6f22f5 |
toririm
reviewed
Sep 28, 2024
toririm
reviewed
Sep 28, 2024
toririm
reviewed
Sep 28, 2024
toririm
requested changes
Sep 28, 2024
toririm
reviewed
Sep 28, 2024
toririm
requested changes
Sep 29, 2024
app/routes/_header.casher.tsx
Outdated
| @@ -1,10 +1,10 @@ | |||
| import { parseWithZod } from "@conform-to/zod"; | |||
| // import { parseWithZod } from "@conform-to/zod"; | |||
There was a problem hiding this comment.
消しちゃおう～
Suggested change
| // import { parseWithZod } from "@conform-to/zod"; |
app/routes/_header.casher.tsx
Outdated
| import { AlertDialogCancel } from "@radix-ui/react-alert-dialog"; | ||
| import { TrashIcon } from "@radix-ui/react-icons"; | ||
| import type { ClientActionFunction } from "@remix-run/react"; | ||
| // import type { ClientActionFunction } from "@remix-run/react"; |
There was a problem hiding this comment.
Suggested change
| // import type { ClientActionFunction } from "@remix-run/react"; |
app/routes/_header.casher.tsx
Outdated
| import { useState } from "react"; | ||
| import useSWRSubscription from "swr/subscription"; | ||
| import { z } from "zod"; | ||
| // import { z } from "zod"; |
There was a problem hiding this comment.
Suggested change
| // import { z } from "zod"; |
app/routes/_header.casher.tsx
Outdated
| @@ -28,11 +28,12 @@ import { | |||
| } from "~/components/ui/table"; | |||
| import { itemConverter, orderConverter } from "~/firebase/converter"; | |||
| import { collectionSub } from "~/firebase/subscription"; | |||
| import { stringToJSONSchema } from "~/lib/custom-zod"; | |||
| // import { stringToJSONSchema } from "~/lib/custom-zod"; | |||
There was a problem hiding this comment.
Suggested change
| // import { stringToJSONSchema } from "~/lib/custom-zod"; |
app/routes/_header.casher.tsx
Outdated
| import { OrderEntity, orderSchema } from "~/models/order"; | ||
| import { itemRepository } from "~/repositories/item"; | ||
| import type { ItemEntity } from "~/models/item"; | ||
| // import { OrderEntity, orderSchema } from "~/models/order"; |
There was a problem hiding this comment.
Suggested change
| // import { OrderEntity, orderSchema } from "~/models/order"; |
app/routes/_header.casher.tsx
Outdated
| import type { ItemEntity } from "~/models/item"; | ||
| // import { OrderEntity, orderSchema } from "~/models/order"; | ||
| import { OrderEntity } from "~/models/order"; | ||
| // import { itemRepository } from "~/repositories/item"; |
There was a problem hiding this comment.
Suggested change
| // import { itemRepository } from "~/repositories/item"; |
|
Biomeの拡張機能が入ってたら保存時に不要なインポートが自動で消されるはずなので入ってなかったら入れてみてね～ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #158
close #115
total の自動計算により、state 管理を order 単位から items 単位に