Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

受領後の画面作成 #33

Merged
merged 3 commits into from
Aug 30, 2024
Merged

受領後の画面作成 #33

merged 3 commits into from
Aug 30, 2024

Conversation

Astalum
Copy link
Member

@Astalum Astalum commented Aug 28, 2024

ref #4

  • 合計金額は mockOrder の total から取得
  • 受領額の入力規制はかけていない
  • 次へ進むで確認画面を表示
  • 確認画面では合計金額・受領額・お釣りを表示

@Astalum Astalum requested a review from toririm August 28, 2024 21:52
@Astalum Astalum self-assigned this Aug 28, 2024
Copy link
Member

@toririm toririm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ダイアログを使った確認画面のアイデアいいね!!

ただ、ここで依存してる@radix-ui/react-alert-dialogがpackage.jsonとbun.lockbに含まれてないからビルドが落ちてるかも

bun add @radix-ui/react-alert-dialog

を実行して発生するpackage.jsonとbun.lockbの差分をコミットしよう!

@toririm
Copy link
Member

toririm commented Aug 29, 2024

ちなみに、shadcn/uiではコンポーネントを追加した際に、自動で依存パッケージのインストールが行われます!
package.jsonが変更されていたら、bun.lockbと合わせてコミットに含めるよう、気を付けてみるといいかも

Copy link
Contributor

Visit the preview URL for this PR (updated for commit daf1fbc):

https://cafeore-2024--pr33-casher-54jv00tk.web.app

(expires Fri, 06 Sep 2024 05:14:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b62dcde668e26b6280dd8317f3f875013f6f22f5

@Astalum
Copy link
Member Author

Astalum commented Aug 30, 2024

不足分コミットしました~

Copy link
Member

@toririm toririm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Astalum

マージお願いします!

LGTMeow

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

実は

+ cashier
- casher

らしい

@Astalum Astalum merged commit 85b0167 into main Aug 30, 2024
2 checks passed
@toririm toririm deleted the casher branch August 30, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants