Fix dependsOn bug when string is not an asset #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix dependsOn bug when string is not an asset or when dependency is empty
isJs
,isCss
,isBonsai
namespace
to all files by mistakebonsai/src/Assets.php
Lines 43 to 45 in 466603f
bonsai/src/Assets.php
Line 43 in 466603f
bonsai/src/Assets.php
Line 165 in 466603f
bonsai/src/Assets.php
Line 201 in 466603f
parseBonsai
bonsai/src/Assets.php
Line 194 in 466603f
bonsai/src/Assets.php
Line 211 in 466603f
dependsOn
when by mistake youBonsai::add
a non asset file likefavico.ico
and it has dependency withdependsOn
, it adds the dependency to the las asset added beforefavico.ico
,so if it is not asset clean
lastAddedAsset
property with$this->lastAddedAsset = '';
bonsai/src/Assets.php
Lines 48 to 52 in 466603f
parseBonsai
, now is posible to do this@kaidesu it works the same, just validations added and it's better now