Fix using schema option with connection option #2316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasterOdin
force-pushed
the
fix-connection-option
branch
from
e0cf5bc
to
fc67c05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2315
Fixes a bug where if using the
connectionandschemaoptions, the adapter would attempt to create the migrations log table in the default schema (public) vs the one in theschemaoption.This was due to
PdoAdaptercallingsetConnectionifconnectionwas set, and as part of that logic the migration log table is created. The fix is to just make sure we set$schemabefore we callparent::setOptionsin thePostgresAdapter.