Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transform_warehouse errors #3679

Merged
merged 3 commits into from
Feb 7, 2025
Merged

Conversation

erikamov
Copy link
Contributor

@erikamov erikamov commented Feb 7, 2025

Description

This PR fixes table creation errors happening on transform_warehouse:

  • models/staging/ntd_safety_and_security/stg_ntd__monthly_modal_time_series_safety_and_service.sql
    and models/staging/ntd_safety_and_security/stg_ntd__nonmajor_safety_and_security_events.sql
    Error: Unable to coerce type FLOAT64 to expected type STRING
    Fixed the typecast.

  • models/intermediate/gtfs_quality/int_gtfs_quality__outcome_validator_versions.sql and
    models/mart/gtfs_quality/fct_daily_schedule_feed_validation_notices.sql
    Error: Invalid BIGNUMERIC value: STOP Field: locationType; Value: STOP
    Fixed the external_table data type.

  • models/mart/gtfs/dim_pathways.sql
    Error: Invalid NUMERIC value: 65.00730846754857 Field: length; Value: 65.00730846754857
    Fixed the external_table data type.

Resolves #3514

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How has this been tested?

Tested locally creating models on staging.

Screenshot 2025-02-06 at 4 38 24 PM
Screenshot 2025-02-06 at 4 38 41 PM
Screenshot 2025-02-06 at 4 38 57 PM

Post-merge follow-ups

  • No action required
  • Actions required (specified below)

Validate the successful creation of those tables and no more errors on transform_warehouse.dbt_run_and_upload_artifacts.

“Invalid NUMERIC value: 65.00730846754857 Field: length; Value: 65.00730846754857” from transform_warehouse

[#3514]

Signed-off-by: Doc Ritezel <[email protected]>
“Invalid BIGNUMERIC value: STOP Field: locationType; Value: STOP” from transform_warehouse

Signed-off-by: Doc Ritezel <[email protected]>
Copy link

github-actions bot commented Feb 7, 2025

Warehouse report 📦

DAG

Legend (in order of precedence)

Resource type Indicator Resolution
Large table-materialized model Orange Make the model incremental
Large model without partitioning or clustering Orange Add partitioning and/or clustering
View with more than one child Yellow Materialize as a table or incremental
Incremental Light green
Table Green
View White

Copy link
Contributor

@ohrite ohrite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍐 paired with @erikamov

@erikamov erikamov merged commit 87c2868 into main Feb 7, 2025
4 checks passed
@erikamov erikamov deleted the 3514-fix-transfor-warehouse-errors branch February 7, 2025 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: dim pathways issue
2 participants