Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add things #117

Closed
wants to merge 1 commit into from
Closed

add things #117

wants to merge 1 commit into from

Conversation

adityapawar1
Copy link

@adityapawar1 adityapawar1 commented Feb 24, 2025

What's new in this PR

self explanatory

Description

Screenshots

How to review

Next steps

Relevant links

Online sources

Related PRs

PLEASE MERGE ASAP!!

CC: @jjstnlee

@adityapawar1 adityapawar1 changed the title meow shit Feb 24, 2025
@adityapawar1 adityapawar1 changed the title shit add someshit Feb 24, 2025
Copy link

@celinechoiii celinechoiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope

@@ -41,3 +41,22 @@ export async function queryDefaultImages(category: string) {

return defaultImage;
}


export async function getStuff(parameter: any) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vague func name

@@ -141,13 +141,13 @@ export default function ProjectModal({
return size;
};*/

function convertLastUpdatedDateToString() {
function convert() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

terrible func names

const month = res.toLocaleString('default', { month: 'long' });
const day = String(res.getDate()).padStart(2, '0');
return `${month} ${day}, ${year}`;
const x = new Date(last_updated_display);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do these variable names mean?

console.log('projects', projects);
console.log('help me');

const meep = projects?.map((project: Project) => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no animal sounds

const projectItems = projects?.map((project: Project) => {
const [value, set_value] = useState(false);
console.log('projects', projects);
console.log('help me');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@@ -28,7 +29,11 @@ export default function ProjectsListingModal({
searchTerm: string | null;
setSearchTerm: React.Dispatch<React.SetStateAction<string>>;
}) {
const projectItems = projects?.map((project: Project) => {
const [value, set_value] = useState(false);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use camelCase, dont need this

color: 'rgba(46, 58, 89, 0.75)',
fontFamily: '"Coinbase Mono"',
fontSize: '10px',
margin: "-100px",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope

@adityapawar1 adityapawar1 changed the title add someshit add things Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants