Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] implented confirm password #31

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

rachaelch3n
Copy link
Contributor

What's new in this PR 🧑‍🌾

Description

  • Separated the auth flow into two pages: /login and /signup.
  • Added a "confirm password" input on the signup page that displays an error if the password and confirm password inputs do not match.
  • Implemented the ability to show or hide password inputs for both "password" and "confirm password" fields.
  • Incorporated checks for password complexity (at least 8 characters, at least one number, and at least one lowercase character).
  • Disabled the signup button until there are no errors (password and confirm password match, and complexity checks are met).

Screenshots

No checks passed
Screen Shot 2024-11-04 at 2 26 22 AM
Some checks passed
Screen Shot 2024-11-04 at 2 27 26 AM
Complexity checks passed but passwords don't match
Screen Shot 2024-11-04 at 2 28 10 AM
All checks passed and signup button is enabled
Screen Shot 2024-11-04 at 2 28 34 AM
Toggle visibility
Screen Shot 2024-11-04 at 2 29 13 AM

How to review

  • Review the PasswordComplexity and PasswordInput implementation in utils
  • Test the login flow in login page.tsx and ensure signIn work as expected
  • Test the login flow in signup page.tsx and ensure signUp work as expected

Next steps

  • styling

Relevant links

Online sources

Related PRs

CC: @ccatherinetan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant