[feat] User Auth: Created a simple login page that supports sign up and sign in. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin3656
reviewed
Oct 7, 2024
app/(auth)/login/page.tsx
Outdated
| <button type="button" onClick={handleSignUp}> | ||
| Sign up | ||
| </button> | ||
| <button type="button" onClick={signInWithEmail}> |
There was a problem hiding this comment.
I think this looks good, maybe could put some identifier for where the email goes and where the password goes for signup/login
There was a problem hiding this comment.
good point! maybe consider creating a placeholder for each of the text inputs
e.g. https://developer.mozilla.org/en-US/docs/Web/CSS/::placeholder
<input placeholder="Email" /> and <input placeholder="Password" />
There was a problem hiding this comment.
looking good! even tho we don't have the final designs, it would be nice to have some way to confirm that sign up / sign in has worked.
- for now, maybe u can route the user to home page after clicking either button
- maybe add a placeholder to both inputs to distinguish them for now.
- you can consider creating some general styles (e.g. centering each input/button etc) to practice Styled Components!
SashankBalusu
pushed a commit
that referenced
this pull request
Oct 9, 2024
|
Apart from the previous comments it looks good and tests great for me! |
rachaelch3n
changed the title
ccatherinetan
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR 🧑🌾
Description
Create a very simple login page that supports sign up and sign in.
Screenshots
How to review
Next steps
Relevant links
Online sources
Related PRs
CC: @ccatherinetan