Merge pull request Expensify#52021 from teneeto/fix/50818/attachment-…

…modal-position fix: attachment menu position
callstack-internal · Nov 18, 2024 · 4829ac9 · 4829ac9
2 parents 8e1b0fd + 52985d0
commit 4829ac9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/src/hooks/useWindowDimensions/index.ts b/src/hooks/useWindowDimensions/index.ts
@@ -129,10 +129,8 @@ export default function (useCachedViewportHeight = false): WindowDimensions {
         return windowDimensions;
     }
 
-    const didScreenReturnToOriginalSize = lockedWindowDimensionsRef.current.windowWidth === windowWidth && lockedWindowDimensionsRef.current.windowHeight === windowHeight;
-
     // if video exits fullscreen mode, unlock the window dimensions
-    if (lockedWindowDimensionsRef.current && !isFullScreenRef.current && didScreenReturnToOriginalSize) {
+    if (lockedWindowDimensionsRef.current && !isFullScreenRef.current) {
         const lastLockedWindowDimensions = {...lockedWindowDimensionsRef.current};
         unlockWindowDimensions();
         return {windowWidth: lastLockedWindowDimensions.windowWidth, windowHeight: lastLockedWindowDimensions.windowHeight};

diff --git a/src/pages/home/report/ContextMenu/ReportActionContextMenu.ts b/src/pages/home/report/ContextMenu/ReportActionContextMenu.ts
@@ -64,8 +64,7 @@ function hideContextMenu(shouldDelay?: boolean, onHideCallback = () => {}) {
         return;
     }
     if (!shouldDelay) {
-        contextMenuRef.current.hideContextMenu(onHideCallback);
-
+        onHideCallback();
         return;
     }