Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android) Fix crash with navigation on fabric #913

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

MrRefactor
Copy link
Collaborator

@MrRefactor MrRefactor commented Nov 16, 2024

Summary

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS ✅❌
Android ✅❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)

@ednilsoncs
Copy link

I was testing it, and everything seems to be working without any issues. However, I was thinking if it might be necessary to make some correlated changes on the iOS counterpart as well. I came across a similar comment regarding a problem on the iOS platform.

Anyway, happy to help. Thanks for the PR, @MrRefactor!

@MrRefactor MrRefactor merged commit e6f63c2 into master Nov 19, 2024
2 checks passed
@MrRefactor MrRefactor deleted the fix/crash-navigation-fabric branch November 19, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants