Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(iOS): fix component layout issue #915

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix(iOS): fix component layout issue #915

merged 1 commit into from
Nov 19, 2024
+6 −10

Conversation

krozniata
Copy link
Member

Summary

This PR fixes issue with views not being correctly recycled on new arch, causing components styles miscalculations

Test Plan

  1. Open example app
  2. Navigate through examples a lot – e.g BasicExample -> PaginationDotsExample -> HeadphonesExample -> again PaginationDotsExample etc.
  3. No layout issues should appear, rest should work as before

Compatibility

OS Implemented
iOS ✅
Android ❌

cipolleschi
cipolleschi approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code makes sense to me. I think it is also what we have to do in RNGesture Handler to fix some issues: software-mansion/react-native-gesture-handler#2926

Out of curiosity, why we have ios/LEGACY/Fabric path? Do we have a non legacy one? Which one is used in prod?

@troZee
Copy link
Member

troZee commented Nov 19, 2024

@cipolleschi

**Out of curiosity, why we have ios/LEGACY/Fabric path? Do we have a non legacy one? Which one is used in prod?**

We will remove that in the future. We had plans to change a pager engine, but it does not work well.

MrRefactor
MrRefactor approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@MrRefactor MrRefactor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tested - works fine

@MrRefactor MrRefactor merged commit 06c8e8f into master Nov 19, 2024
2 checks passed
@MrRefactor MrRefactor deleted the fix/recycle-issue branch November 19, 2024 17:53
@MrRefactor
Copy link
Collaborator

@cipolleschi released in https://github.com/callstack/react-native-pager-view/releases/tag/v6.5.1

@brentvatne brentvatne mentioned this pull request Nov 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrRefactor MrRefactor MrRefactor approved these changes

@troZee troZee troZee approved these changes

@cipolleschi cipolleschi cipolleschi approved these changes

@okwasniewski okwasniewski Awaiting requested review from okwasniewski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krozniata @troZee @MrRefactor @cipolleschi