Changed 'wakeword' to 'audiosample' to better reflect the backend table. #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will break the current web recorder until it is updated to reflect the new endpoint. |
|
I was thinking it could be as simple as |
mfekadu
requested changes
Feb 18, 2020
| @@ -69,7 +69,7 @@ def handle_question(): | |||
| return jsonify(response), SUCCESS | |||
|
|
|||
|
|
|||
| @app.route('/new_data/wakeword', methods=['POST']) | |||
| @app.route('/new_data/audiosample', methods=['POST']) | |||
There was a problem hiding this comment.
let's go with /audiosample to keep it simple
There was a problem hiding this comment.
@Waidhoferj what are your thoughts?
There was a problem hiding this comment.
I have no preference either way.
|
Closing since this is super small and super old. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's New?
This addresses #44 - Refactor API for data upload.
Fixes #<<ISSUE_NUMBER>> ... (e.g. #9)
Type of change (pick-one)
How Has This Been Tested?
Tested locally using firefox/postman
Checklist (check-all-before-merge)
formatting help:
- [x]means "checked' and- [ ]means "unchecked"I documented my code according to the Google Python Style Guide
I ran
./build_docs.shand the docs look fineI ran
./type_check.shand got no errorsI ran
./format.shbecause it automatically cleans my code for me 😄I ran
./lint.shto check for what "format" missedI added my tests to the
/testsdirectoryI ran
./run_tests.shand all the tests pass