Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added multi-round tests for azure_openai_model #1531

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Rkejji
Copy link
Collaborator

@Rkejji Rkejji commented Jan 31, 2025

Description

Added unit test to test_azure_open_ai_model while mocking API calls to the real openai API.

Motivation and Context

This PR is related to this issue #1513

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@Rkejji Rkejji requested a review from Wendong-Fan January 31, 2025 18:00
Copy link
Member

@Wendong-Fan Wendong-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Rkejji , sorry for the late review, it looks great! Thanks for the contribution!

@Wendong-Fan Wendong-Fan added this to the Sprint 22 milestone Feb 4, 2025
@Rkejji
Copy link
Collaborator Author

Rkejji commented Feb 4, 2025

@Wendong-Fan please use this PR instead #1550
It will contain all the unit tests for the models not only the azure_openai_model

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants