Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance User Registration with Input Validation and Success Feedback #908

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

Lochipi
Copy link
Contributor

@Lochipi Lochipi commented Mar 29, 2024

Summary

This Pull Request introduces enhancements to the user registration feature. It implements validation for email and filters inputs, ensuring that error messages are displayed only for the relevant input. Additionally, it adds a success popup to provide feedback to users upon successful registration and clears up the input fields.

Snips

image
image
image
image

Motivation

The motivation behind this PR is to improve the user experience during the registration process. By validating inputs and providing clear error messages, users can easily identify and correct any issues before submitting the form. The addition of a success popup further enhances user feedback, confirming successful registration and improving overall satisfaction.

Implementation

  • Added validation functions for email and filters inputs.
  • Modified the addUser function to display error messages only for the relevant input.
  • Integrated a success popup to appear upon successful registration, providing immediate feedback to the user.

Video demo

Recording.4.mp4

Testing

I have conducted testing to ensure the following:

  • Error messages are displayed only for the relevant input field.
  • Success popup appears upon successful registration and disappears after a specified duration.
  • Input fields are cleared after successful registration.
  • User experience is enhanced with clear feedback and validation.

I have also run the linting to fix any potential errors, and it's working fine.
image

Questions

If you have any feedback or suggestions regarding this PR, please feel free to share them. And also, if there's anything else you'd like me to address, let me know. Thanks.

@Lochipi
Copy link
Contributor Author

Lochipi commented Mar 31, 2024

Hey there, @birm , can you take a look at this pr, lemme know the changes if needed.

Copy link

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Nov 24, 2024
Copy link
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution; while the signup process is still tricker than it probably ought to be, this is a strong improvement. Thank you!

@birm birm merged commit 342dfde into camicroscope:develop Jan 23, 2025
0 of 2 checks passed
@Lochipi
Copy link
Contributor Author

Lochipi commented Jan 23, 2025

Sure, let's catch up on slack and lemme know what area needs improvements and we'll work on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants