Matias Rodeghiero #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Se agregó que devuelva un símbolo # para el caso que no se adivine ningún número además de validaciones extras.
| if trueNumber == '': | ||
| return 'Number is not defined' | ||
| def __init__(self): | ||
| self.TRUE_NUMBER = '1025' |
|
|
||
| if numero == trueNumber: | ||
| return True | ||
| def adivinar(self, intento=0, numero=None): |
There was a problem hiding this comment.
Te recomiendo mantener consistencia entre los nombres de las variables y las funciones en un solo idioma 😄 y quizá ser mas específico, como guess_number.
| if numero == trueNumber: | ||
| return True | ||
| def adivinar(self, intento=0, numero=None): | ||
| self.arrayNumber = [] |
There was a problem hiding this comment.
Recuerda que se recomienda en pep8 usar snake_case para nombrar las variables
Comment on lines
+32
to
+33
| if numero == self.TRUE_NUMBER: | ||
| return intento, True |
There was a problem hiding this comment.
Recuerda intentar mantener un mismo idioma a través de tus variables
| elif numero[x] in self.TRUE_NUMBER: | ||
| self.arrayNumber.append("X") | ||
| else: | ||
| self.arrayNumber.append("#") |
There was a problem hiding this comment.
Podrias modificar la logica para que agrupe primero las (X), luego los (_) bajos y por ultimo los espacios?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.