Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update BPMN modeling libraries #4468

Merged
merged 2 commits into from
Aug 22, 2024
Merged

deps: update BPMN modeling libraries #4468

merged 2 commits into from
Aug 22, 2024

Conversation

Skaiir
Copy link
Contributor

@Skaiir Skaiir commented Aug 20, 2024

Proposed Changes

Updates BPMN modeling dependencies, adding support for #4450.

Closes #4450
Closes #4140
Closes #3534

Validation (for task definition priority)

  • Add a user task
  • Priority field should be available under assignment
  • Should be feel optional
  • Should take any integer between 0 & 100, or a feel expression, and should have corresponding linting rules + properties panel errors when not
  • Should be unsupported pre 8.6, and have corresponding linting rules
  • Should have a tooltip explaining more or less how it works
  • Should set extension property priorityDefinition, attribute priority
  • Should clean the extension property on clearing the priority

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Aug 20, 2024
@barmac
Copy link
Collaborator

barmac commented Aug 21, 2024

Not sure if we can tell the linked issue will be closed via this PR given bpmn-io/bpmn-js-properties-panel#1073 is still open. WDYT?

@Skaiir
Copy link
Contributor Author

Skaiir commented Aug 22, 2024

@barmac Since we are not concerning ourselves with documentation for now due to prios, we can still close it and deal with it independently I believe.

@Skaiir
Copy link
Contributor Author

Skaiir commented Aug 22, 2024

But if you prefer, we can keep the tracking issue. For me it won't make a difference I'll just unassign myself from the tracking :).

@nikku nikku self-requested a review August 22, 2024 07:54
@nikku
Copy link
Member

nikku commented Aug 22, 2024

@Skaiir I'd just like you to connect the follow-ups to whatever epic you work on. From our end it is fine to incrementally ship things, hence 👍 for closing the issue, with some follow-ups to do.

Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can enter strings in the field, which I'm not sure is expected:

screenshot EQmVEl

I cannot see any validation (not supported pre-8.6).


I propose we take this the usual route, integrate a working thing in camunda-bpmn-js, and take it from there.

@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Aug 22, 2024
@nikku
Copy link
Member

nikku commented Aug 22, 2024

Skaiir and others added 2 commits August 22, 2024 11:41
Validates zeebe:priorityDefinition:priority.

Related to #4450
@nikku nikku changed the title deps: [email protected] & [email protected] deps: update to camunda-bmp Aug 22, 2024
@nikku nikku changed the title deps: update to camunda-bmp deps: update BPMN modeling libraries Aug 22, 2024
@nikku nikku added the dependencies Updates a dependency label Aug 22, 2024
@nikku
Copy link
Member

nikku commented Aug 22, 2024

This now bumps all modeling dependencies, consistently via camunda-bpmn-js, and includes the latest version of linting, too.

@Skaiir I strongly suggest you to get your DEV setup for the modeler sorted, so you can efficiently test this locally. We're not the ones to do primary user testing 🙈, but we want you to verify the definition of done yourself, before you move the PR to needs review.

@nikku nikku self-requested a review August 22, 2024 09:53
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Aug 22, 2024
@nikku nikku merged commit 1e96185 into develop Aug 22, 2024
14 checks passed
@nikku nikku deleted the 4450-user-task-priority branch August 22, 2024 09:58
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 22, 2024
@github-actions github-actions bot added this to the M80 milestone Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Updates a dependency
Projects
None yet
3 participants