Skip to content

Commit

Permalink
Add version of the RxPlayer in the debug element
Browse files Browse the repository at this point in the history
I like relying on our debug element feature when debugging elements and
other users seem to also find that element useful, sharing to us screen
captures/recording of it.

In that context, it could be good to also display the current RxPlayer
version in it, so we can quickly know which version is currently relied
on.
  • Loading branch information
peaBerberian committed Oct 10, 2024
1 parent b21b9ba commit 4729866
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions doc/api/Miscellaneous/Debug_Element.md
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ exactly what's going on at a particular point in time.
buffering media) also running in a WebWorker (which should be more efficient but is
supported by less platforms).
- If set to `0`, the playback is in the regular "main" (single thread) mode.
- **v**: Current version of the RxPlayer.
- **ks**: _Key System_. If set, the current key system used to decrypt contents.
- **mbb**: _Max Buffer Behind_. If set, the configured `maxBufferBehind` (amount of
buffer to keep in memory behind the current position, in seconds).
Expand Down
2 changes: 1 addition & 1 deletion src/main_thread/api/debug/modules/general_info.ts
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export default function constructDebugGeneralInfo(
valuesLine1.push(["wo", "0"]);
}

const valuesLine2: Array<[string, string]> = [];
const valuesLine2: Array<[string, string]> = [["v", instance.version]];
const ks = instance.getKeySystemConfiguration();
if (ks !== null) {
valuesLine2.push(["ks", ks.keySystem]);
Expand Down

0 comments on commit 4729866

Please sign in to comment.