[TEST] Breaking performance tests

.github/workflows/perfs.yml

@@ -1,24 +1,63 @@
 name: Performance tests
+
 on:
   pull_request:
-    types: [labeled]
+    types: [opened, synchronize, reopened]
+
+# Abort if new commit since then
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
+  cancel-in-progress: true
 
 jobs:
   perf-tests:
-    if: ${{ github.event.label.name == 'Performance checks' }}
+    if: ${{ !contains(github.event.pull_request.labels.*.name, 'skip-performance-checks') }}
     runs-on: [ubuntu-latest]
+    permissions:
+      pull-requests: write
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - name: Use Node.js ${{ matrix.node-version }}
         uses: actions/setup-node@v2
         with:
           node-version: ${{ matrix.node-version }}
           cache: "npm"
       # needed for integration & memory tests codecs support
+      - run: echo "${{ contains(github.event.pull_request.labels.*.name, 'skip-performance-checks') }}"
+      - run: echo "${{ contains(github.event.pull_request.labels.*.name, 'totoleheros') }}"
+      - run: echo "${{ !contains(github.event.pull_request.labels.*.name, 'skip-performance-checks') }}"
+      - run: echo "${{ !contains(github.event.pull_request.labels.*.name, 'totoleheros') }}"
+      - run: echo "${{ toJson(github.event.issue.labels) }}"
+      - run: echo "toto"
+      - run: echo "${{ toJson(github.event.issue.labels.*.name) }}"
+
       - run:
           sudo add-apt-repository multiverse && sudo apt update && sudo apt install -y
           ubuntu-restricted-extras
       - run: npm ci
       - run: export DISPLAY=:99
       - run: sudo Xvfb -ac :99 -screen 0 1280x1024x24 > /dev/null 2>&1 & # optional
-      - run: node tests/performance/run.mjs
+      - run:
+          node tests/performance/run.mjs --branch $GITHUB_BASE_REF --remote-git-url
+          https://github.com/canalplus/rx-player.git --report perf-report.md
+      - name: Post comment
+        if: always()
+        uses: actions/github-script@v7
+        with:
+          script: |
+            const { readFileSync, existsSync } = require('fs');
+            if (!existsSync("./perf-report.md")) {
+              return;
+            }
+            const fileContent =  readFileSync("./perf-report.md").toString();
+            github.rest.issues.createComment({
+              issue_number: context.issue.number,
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              // TODO: generate comment header inside the report file instead of here for better portability?
+              // We should already have access to the sha1 through `git` and the destination branch through the command line arguments.
+              body: "Automated performance checks have been performed on commit " +
+                    "\`${{github.event.pull_request.head.sha}}\` with the base branch \`${{github.base_ref}}\`.\n\n" +
+                    fileContent +
+                    "\n\n If you want to skip performance checks for latter commits, add the `skip-performance-checks` label to this Pull Request.",
+            })

.gitignore

@@ -7,8 +7,8 @@
 /demo/worker.js
 
 /tests/performance/node_modules
-/tests/performance/bundle1.js
-/tests/performance/bundle2.js
+/tests/performance/previous.js
+/tests/performance/current.js
 /tests/performance/package.json
 /tests/performance/package-lock.json
 

src/core/main/worker/worker_main.ts

@@ -594,7 +594,7 @@ function loadOrReloadPreparedContent(
   );
 
   StreamOrchestrator(
-    { initialPeriod: manifest.periods[0], manifest },
+    { initialPeriod, manifest },
     playbackObserver,
     representationEstimator,
     segmentSinksStore,

src/main_thread/init/media_source_content_initializer.ts

@@ -57,6 +57,7 @@ import isNullOrUndefined from "../../utils/is_null_or_undefined";
 import noop from "../../utils/noop";
 import objectAssign from "../../utils/object_assign";
 import type { IReadOnlySharedReference } from "../../utils/reference";
+import sleep from "../../utils/sleep";
 import type { ISyncOrAsyncValue } from "../../utils/sync_or_async";
 import SyncOrAsync from "../../utils/sync_or_async";
 import type { CancellationSignal } from "../../utils/task_canceller";
@@ -205,6 +206,10 @@ export default class MediaSourceContentInitializer extends ContentInitializer {
     );
 
     this._setupInitialMediaSourceAndDecryption(mediaElement)
+      .then(async (initResult) => {
+        await sleep(200);
+        return initResult;
+      })
       .then((initResult) =>
         this._onInitialMediaSourceReady(
           mediaElement,

tests/performance/index1.html → tests/performance/current.html

@@ -3,7 +3,7 @@
   <head>
     <meta charset="UTF-8" />
     <meta name="viewport" content="width=device-width,initial-scale=1" />
-    <script type="text/javascript" src="./bundle1.js" charset="utf-8"></script>
+    <script type="text/javascript" src="./current.js" charset="utf-8"></script>
     <title>RxPlayer - Performance tests</title>
   </head>
   <body>

tests/performance/index2.html → tests/performance/previous.html

@@ -3,7 +3,7 @@
   <head>
     <meta charset="UTF-8" />
     <meta name="viewport" content="width=device-width,initial-scale=1" />
-    <script type="text/javascript" src="./bundle2.js" charset="utf-8"></script>
+    <script type="text/javascript" src="./previous.js" charset="utf-8"></script>
     <title>RxPlayer - Performance tests</title>
   </head>
   <body>