Upgrade most dependencies but vitest and eslint #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is one of our regular dependency update commit, most importantly esbuild to `0.25` and vitest to `3.x.x`.
Turns out following the seemingly mininal [vitest 3 migration guide](https://vitest.dev/guide/migration) did not work for our case: when running on a browser, none of our test would run and just an exit code 1 would be returned. Running in a Node.js env however did work. I also tried to restart from their config-generating tool, but nope, I did not succeed to run it, nor did I found how to output logs that would explain what's going on internally leading to this situation. Consequently, I'm keeping open the other PR which tries to update vitest for the long term but I also opened this one which updates vitest while staying in v2.x.x. (Also small rant, but the weird introduction brag in their [v3 release note](https://vitest.dev/blog/vitest-3) about having released vitest v2 "half a year ago" seems kind of tone-deaf to me, I would guess most developers are generally far from happy to see a library doing new major versions, let alone so fast after the last one! - And yes I'm salty I did not succeed to migrate to it.). Like eslint 9, this is the second library I'm not succeeding to upgrade though, we will have to find a solution at some point for both of those.
|
Automated performance checks have been performed on commit Tests results✅ Tests have passed. Performance tests 1st run outputNo significative change in performance for tests:
If you want to skip performance checks for latter commits, add the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out following the seemingly mininal vitest 3 migration guide did not work for our case: when running on a browser, none of our test would run and just an exit code 1 would be returned. Running in a Node.js env however did work.
I also tried to restart from their config-generating tool, but nope, I did not succeed to run any tests even there, nor did I found how to output logs that would explain what's going on internally leading to this situation.
Consequently, I'm keeping open the other PR which tries to update vitest for the long term but I also opened this one which updates vitest while staying in v2.x.x.
(Also small rant, but the weird introduction brag in their v3 release note about having released vitest v2 "half a year ago" seems kind of tone-deaf to me, I would guess most developers are generally far from happy to see a library doing new major versions, let alone so fast after the last one! - And yes I'm salty I did not succeed to migrate to it.).
Like eslint 9, this is the second library I'm not succeeding to upgrade though, we will have to find a solution at some point for both of those.