Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: pin deployed charms to a latest and stable version #164

Merged
merged 7 commits into from
Apr 16, 2024

Conversation

DnPlas
Copy link
Contributor

@DnPlas DnPlas commented Apr 11, 2024

This commit pins all charms that get deployed from Charmhub to a latest/edge or suggested versions.
Part of canonical/bundle-kubeflow#863

This commit pins all charms that get deployed from Charmhub to a compatible version to
the CKF 1.8 release. This commit also refactors the test file so it takes all versions and other
constants from a constants.py file

Part of canonical/bundle-kubeflow#863
@DnPlas DnPlas requested a review from a team as a code owner April 11, 2024 13:04
@DnPlas DnPlas changed the title tests: pin deployed charms to a CKF 1.8 compatible version tests: pin deployed charms to a latest and stable version Apr 11, 2024
Copy link
Member

@misohu misohu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked the changes and looks right. LGTM

@DnPlas DnPlas merged commit af913c8 into main Apr 16, 2024
12 checks passed
@DnPlas DnPlas deleted the KF-5537-pin-charm-deps-in-mian branch April 16, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants